BC2A-1408: Remove duplicate base64_encode #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
9 times, most recently
from
9feb36f to
381fb9e
Compare
fbeutin-ledger
previously approved these changes
Nov 27, 2023
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
381fb9e to
7eb0765
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
2 times, most recently
from
87cdeb6 to
7eb0765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
base64_encodewas duplicated between the App itself and thezxlibdependency. This PR allows to clean up the code:In addition, this PR fixes the Stax compilation, which fails with latest SDK
Note: The build fails on the latest NanoS SDK, because of macro redefinition:
UNUSED