Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #54 #55

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix #54 #55

merged 1 commit into from
Nov 15, 2023

Conversation

yhql
Copy link
Collaborator

@yhql yhql commented Nov 14, 2023 •
edited
Loading

pin_fault.py was missing the setup of reference PIN and input PIN storages for the last "reference" trace

Fixes #54

@yhql yhql mentioned this pull request Nov 14, 2023
Closed
schaefflerf
schaefflerf approved these changes Nov 15, 2023
View reviewed changes
Copy link

@schaefflerf schaefflerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now, thanks!

@yhql yhql merged commit ba656a6 into master Nov 15, 2023
@yhql yhql deleted the fix/pin_fault branch November 15, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaefflerf schaefflerf schaefflerf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pin_fault.py does not run PyQt5 with default input_pin_adress
2 participants
@yhql @schaefflerf