Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include erratum for Witnesses #89

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

ChristianKurz
Copy link

@ChristianKurz ChristianKurz commented Nov 21, 2024

Fix #41

Marking as draft since i'm not quite sure if the format is correct:
Some errata end in ''" with only one corresponding opening single quote '. I went with what seemed most reasonable to me.

@seiyria
Copy link
Member

seiyria commented Nov 24, 2024

Apologies, I either didn't know about this PR or missed it somehow. The ending depends on what the text has in it, puncuation-wise, because while YAML is great, it's also hell. Generally speaking, I would say that if the build passes (it's currently running), then you've got the format correct.

@jdyearsley jdyearsley marked this pull request as ready for review December 19, 2024 16:43
Edited pull request slightly to match game style.
@jdyearsley jdyearsley changed the base branch from master to 2025-Update1 December 19, 2024 16:49
@jdyearsley
Copy link
Contributor

I'll be merging this into the next update that we will push all at once. Thank you for entering this!

@jdyearsley jdyearsley closed this Dec 19, 2024
@jdyearsley jdyearsley reopened this Dec 19, 2024
@jdyearsley jdyearsley merged commit a0a89fa into LederCards:2025-Update1 Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Arcs] [FAQ ready] Witness FAQ -> errata
3 participants