Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing append to optimize memory usage #93

Open
wants to merge 3 commits into
base: piegames/noise-transit
Choose a base branch
from

Conversation

donpui
Copy link

@donpui donpui commented Nov 24, 2022

We run diagnostic with pprof (go tool pprof -alloc_space -cum http://localhost:8081/debug/pprof/heap) to check memory usage and made several changes to optimise, when sending large files via w-w CLI


Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@donpui donpui requested review from piegamesde and vu3rdd November 28, 2022 06:59
@piegamesde
Copy link
Collaborator

piegamesde commented Nov 28, 2022

The CI consistently fails even after a couple of retrys, not really sure why.

@donpui
Copy link
Author

donpui commented Dec 14, 2022

Rollback append removal, otherwise we send two websocket packages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants