Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete items_by_name example #37

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Complete items_by_name example #37

merged 4 commits into from
Apr 17, 2024

Conversation

alice-i-cecile
Copy link
Contributor

Progress towards #1.

I also swapped the from_name methods to use the correct string borrow abstracting trait.

@alice-i-cecile alice-i-cecile added documentation Improvements or additions to documentation usability Make the crate easier or nicer to use labels Apr 17, 2024
sixfold-origami
sixfold-origami requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@sixfold-origami sixfold-origami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, but you should call out which parts are copied from simple.rs, like in the custom asset loading example

@sixfold-origami sixfold-origami merged commit a2ad914 into main Apr 17, 2024
4 checks passed
@sixfold-origami sixfold-origami deleted the items-by-name branch April 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixfold-origami sixfold-origami sixfold-origami approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation usability Make the crate easier or nicer to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-i-cecile @sixfold-origami