Make the macros deterministic, using BTreeMap instead of HashMap #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TIL this could be a problem. Sensible fix, thanks. |
This fixes compile errors in non-cargo build systems, which rely on the rustc crate hash being the same between two compiles. HashMap order is nondeterministic due to SipHasher initialization, so macro-generated code would change between compiles.
auto-merge was automatically disabled
December 6, 2024 04:49
Head branch was pushed to by a user without write access
cormacrelf
force-pushed
the
hotfix/macro-determinism
branch
from
cc5045d to
196bc02
Compare
cormacrelf
added a commit
to cormacrelf/leafwing-input-manager
that referenced
this pull request
Dec 10, 2024
…fwing-Studios#662) This fixes compile errors in non-cargo build systems, which rely on the rustc crate hash being the same between two compiles. HashMap order is nondeterministic due to SipHasher initialization, so macro-generated code would change between compiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compile errors in non-cargo build systems, which rely on the rustc crate hash being the same between two compiles (i.e. build with/without codegen).
HashMap order is nondeterministic due to SipHasher initialization, so macro-generated code would change between compiles (in this case, the order of the generated match statement branches).
Can confirm buck2 can now build and link leafwing-input-manager.