Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to a trait-based architecture for UserInput #534

Merged
merged 33 commits into from
Jun 10, 2024
Merged

Conversation

alice-i-cecile
Copy link
Contributor

This adopts #490. See that PR for a full description / context. @Shute052 deserves 99% of the credit here: I just resolved merge conflicts to get this unblocked.

Shute052 and others added 30 commits February 24, 2024 02:01
# Conflicts:
#	src/input_processing/dual_axis/custom.rs
#	src/input_processing/single_axis/custom.rs
# Conflicts:
#	examples/action_state_resource.rs
#	examples/axis_inputs.rs
#	examples/input_processing.rs
#	examples/mouse_wheel.rs
#	examples/virtual_dpad.rs
#	src/axislike.rs
#	src/buttonlike.rs
#	src/input_map.rs
#	src/input_mocking.rs
#	src/input_streams.rs
#	src/user_input.rs
#	tests/gamepad_axis.rs
#	tests/mouse_motion.rs
#	tests/mouse_wheel.rs
# Conflicts:
#	RELEASES.md
#	examples/input_processing.rs
#	src/axislike.rs
#	tests/gamepad_axis.rs
# Conflicts:
#	RELEASES.md
#	src/input_mocking.rs
# Conflicts:
#	RELEASES.md
#	src/plugin.rs
# Conflicts:
#	RELEASES.md
#	examples/input_processing.rs
#	src/axislike.rs
#	src/clashing_inputs.rs
#	tests/gamepad_axis.rs
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) June 10, 2024 16:40
@alice-i-cecile alice-i-cecile added enhancement New feature or request usability Reduce user friction performance Code go brrr controversial Requires a heightened standard of review labels Jun 10, 2024
src/user_input/mod.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile disabled auto-merge June 10, 2024 17:18
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) June 10, 2024 17:20
@alice-i-cecile alice-i-cecile merged commit 6e56c2b into main Jun 10, 2024
4 checks passed
@alice-i-cecile alice-i-cecile deleted the new-architecture branch June 10, 2024 17:35
@Shatur Shatur mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial Requires a heightened standard of review enhancement New feature or request performance Code go brrr usability Reduce user friction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants