Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect axis data in Chord when not all buttons are pressed #432

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Fix incorrect axis data in Chord when not all buttons are pressed #432

merged 4 commits into from
Dec 29, 2023

Conversation

Shute052
Copy link
Collaborator

Fixes #430

alice-i-cecile
alice-i-cecile requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add an entry to RELEASES.md?

@Shute052
Copy link
Collaborator Author

Is there anything else that needs to be changed here?

@alice-i-cecile alice-i-cecile marked this pull request as ready for review December 29, 2023 00:15
@alice-i-cecile alice-i-cecile merged commit d421117 into Leafwing-Studios:main Dec 29, 2023
2 of 4 checks passed
@alice-i-cecile
Copy link
Contributor

Nope, looks great! Thanks a ton.

@Shute052 Shute052 mentioned this pull request Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two inputs (WASD, Mouse button + Mouse Movement) that trigger an action, mouse movement will ignore the chord
2 participants
@Shute052 @alice-i-cecile