-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mouse input events being read multiple times #418
Fix mouse input events being read multiple times #418
Conversation
6006907
to
2b438a0
Compare
let mouse_wheel: Vec<MouseWheel> = mouse_wheel | ||
.get_reader() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no way to correctly read the events from here.
Same thing for the from_world
method on MutableInputStreams
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton <3 Yeah, I'm moving currently but I have a bit in a cafe and I'll merge and ship this.
I think this change broke the egui feature. I'm getting this compile error on 0.11.2
|
Sorry about that. I'll have another PR up in a bit. |
Got a fix for that here: #421. |
@alice-i-cecile I saw you were busy moving at the moment (congrats c:), but this should fix the issue with Bevy 0.12.1 that people mentioned in the discord.
Fixes #285
Cleanest fix I could come up with was to replace the
Events<T>
inInputStreams
withVec<T>
, and then collecting the events into that with anEventReader
inupdate_action_state
.