fix(outline): use the correct symbols and filter config format #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbols-outline extra was removed in favor of outline.nvim, but the configuration for symbols is not backwards-compatible (hedyhli/outline.nvim#12). This fixes the configuration for the symbols icons and filter to be usable by outline.nvim.
|
ty! |
folke
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## [12.26.0](v12.25.0...v12.26.0) (2024-07-05) ### Features * **dial:** yaml support ([f64bbd2](f64bbd2)) * **util:** rest-client ([#3915](#3915)) ([76b41cd](76b41cd)) * **vue:** enabled hybrid mode to avoid 2 typescript lsp running at same time ([#3908](#3908)) ([4b0f720](4b0f720)) ### Bug Fixes * **dial:** move date related augends to default group ([#3927](#3927)) ([4192d95](4192d95)) * **outline:** use the correct symbols and filter config format ([#3924](#3924)) ([502dac1](502dac1)) * **project:** properly close window after changing directory ([#3919](#3919)) ([51e99df](51e99df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The symbols-outline extra was removed in favor of outline.nvim in #2535 (thanks!), but the configuration for symbols in outline.nvim is not backwards-compatible.
This fixes the configuration for the symbols icons and filter to be usable by outline.nvim.
Does this PR fix an existing issue?
It doesn't seem like anyone has encountered this issue, but I can confirm that the config currently used by LazyVim is incorrect. The symbols table is at
symbolsfor symbols-outline.nvim, but it's now atsymbols.iconsfor outline.nvim.There is no such
symbols_blacklistkey. Instead,symbols.filteris used, which is a kind of "whitelist".Coincidentally, outline.nvim fully supports the LazyVim
kind_filterconfig table structure. It can either be a list of strings (kinds), or a list of strings for each filetype key. Setting to nil or false makes it so all symbols are included, just like in LazyVim.See the docs on the
symbols.filterstructure.Checklist