Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use signing key #77

Merged
merged 6 commits into from
Oct 4, 2024
Merged

fix: use signing key #77

merged 6 commits into from
Oct 4, 2024

Conversation

stevennevins
Copy link
Collaborator

No description provided.

@stevennevins stevennevins requested a review from wesfloyd October 1, 2024 21:20
Copy link
Contributor

@wesfloyd wesfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wes CI/CD bot 🤖

forget tests pass

image image

Manual e2e test fails at npm run start:traffic

image image

@stevennevins
Copy link
Collaborator Author

@wesfloyd Fixed the offchain code. I had to put in a quick fix for the threshold stake check since hello world wasn't depositing tokens into a strategy (ie operator has 0 weight). I was already addressing this in my other PR so i just set the required threshold stake to 0 for now

@wesfloyd
Copy link
Contributor

wesfloyd commented Oct 4, 2024

Looks good - ready to merge

image image

Copy link
Contributor

@wesfloyd wesfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - rdy to merge

@stevennevins stevennevins merged commit 191d4bc into master Oct 4, 2024
1 check passed
@stevennevins stevennevins deleted the fix/signing-key-reponse branch October 4, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants