Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] inabox test retrieval from DA nodes #988

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[v2] inabox test retrieval from DA nodes #988

wants to merge 2 commits into from

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Tests retrieval from DA nodes in inabox integration test

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim
Copy link
Contributor Author

To be merged on top of #986

@ian-shim ian-shim marked this pull request as ready for review December 12, 2024 00:31
@ian-shim ian-shim force-pushed the v2-inabox-retrieval branch from 6f5a5f2 to bafd8d0 Compare December 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@anupsv anupsv Awaiting requested review from anupsv

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @cody-littley