Add startup binary management #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelrogstad
force-pushed
the
2023-11-13-startup
branch
2 times, most recently
from
4ad3f97 to
32a968d
Compare
torkelrogstad
commented
Nov 13, 2023
Comment on lines
+250
to
+259
| // TODO: better error message with troubleshooting tips here | ||
| child: _initBinariesError != null | ||
| ? SailText.primary24('Ran into unrecoverable error on startup: $_initBinariesError') | ||
| : loadingIndicator(), |
There was a problem hiding this comment.
@octobocto input appreciated. When this branch is triggered we're at a unrecoverable state, and most likely it's the programmer's fault. Shouldn't happen with the end user, but if it happens they should get a good error message
Comment on lines
+106
to
+105
| // TODO: correct? | ||
| return '.ethereum'; |
There was a problem hiding this comment.
ping test this
|
You should really rebase on master before continuing work here… |
1. Tear out some unecesary OOP crazities 2. Rework the RPC clients such that they don't read RPC credentials on creation, but are passed them as a parameter. We need to construct the clients on startup after reading configuration files, while showing meaningful messages along the way
torkelrogstad
force-pushed
the
2023-11-13-startup
branch
from
32a968d to
355b8e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, we load the
drivechaindbinary from assets, and launch it. The loading spinner is shown until we get a successful connection. In the case of an error, we display a big and ugly error message that it's impossible to get through.TODO:
Load dynamic assets based on platform + architecture