Show current bundle info #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
torkelrogstad
commented
Nov 8, 2023
torkelrogstad
commented
torkelrogstad
force-pushed
the
2023-11-08-bundle
branch
from
a551ed4 to
61f8c39
Compare
octobocto
reviewed
Nov 8, 2023
| // https://github.com/LayerTwo-Labs/testchain/blob/ba78df157fcb9f85d898f65db43c2842ab9473ff/src/policy/corepolicy.h#L25 | ||
| static const double maxWeight = (maxStandardTxWeight / witnessScaleFactor) / 2; | ||
|
|
||
| Map<String, dynamic> get _values => { |
There was a problem hiding this comment.
Is there a reason you cherry-pick fields here? Why not show all of them, always? Future-proofs it. Will never have to look it up in the rpc
There was a problem hiding this comment.
If it is the suffixes you want, you could create a withSuffix() function that looks at the key, and appends a fitting suffix
value: withSuffix(key, _values[key])
There was a problem hiding this comment.
I'm just following the design spec 🫡
octobocto
reviewed
Nov 8, 2023
| width: width, | ||
| child: SailText.secondary12(label), | ||
| ), | ||
| if (label != null) |
There was a problem hiding this comment.
Do we really want this? Should figure out a fitting label instead imo. Can't see it used anywhere
There was a problem hiding this comment.
I use it for the yet-to-be-bundled withdrawals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.