Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign bmm-page #28

Merged
merged 2 commits into from
Nov 4, 2023
Merged

redesign bmm-page #28

merged 2 commits into from
Nov 4, 2023

Conversation

octobocto
Copy link
Collaborator

@octobocto octobocto commented Nov 4, 2023

very open for writing something else in the attempt

Screenshot 2023-11-04 at 12 42 36

@octobocto octobocto changed the title 2023 11 04 bmm redesign bmm-page Nov 4, 2023
),
),
SailText.primary20(
'No BMM attempts yet. Click the start button!\n(and automine at the same time)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that the mainchain is started from the launcher. Could potentially add an option to automine from Sidesail?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we do that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that is a very nice UX, but can we hold off a bit on UX benefits like that until everything is implemented?

next iteration kinda stuff

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep adding these UX things that pop up as we go, but keep the scope as small as possible early on imo.

Can keep track of these things in linear, and add them to a later project iteration

@torkelrogstad
Copy link
Collaborator

On mobile so can't review properly. But from the screen shot: the bid amount is on the mainchain, I.e. regular btc not sbtc. Fees are collected on the sidechain though, so those are sbtc

@torkelrogstad torkelrogstad merged commit 19387be into master Nov 4, 2023
1 check passed
@torkelrogstad torkelrogstad deleted the 2023-11-04-bmm branch November 4, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants