node connection settings #24
Conversation
also change some colors. the components are used in the next few commits
octobocto
force-pushed
the
2023-11-03-node-connection-settings
branch
2 times, most recently
from
493bed8 to
6aea2fd
Compare
octobocto
force-pushed
the
2023-11-03-node-connection-settings
branch
from
6aea2fd to
070cf4f
Compare
octobocto
force-pushed
the
2023-11-03-node-connection-settings
branch
from
00f775d to
1c91922
Compare
It's purpose is to have a universal way to create clients, and keep track of current connection settings. A side effect is that we read config files inside each rpc, and failing initialization doesn't crash the entire app. Reasoning behind not crashing on startup is that an rpc connection can fail at any time, and sidesail should know immediately when a connection is bad! The user might shut down their node, it might crash etc. Sidesail will probably stay open for days at a time. Most people rarely close their applications. It's a bit messy right now, hoping to make it cleaner in a later iteration.
octobocto
force-pushed
the
2023-11-03-node-connection-settings
branch
from
1c91922 to
d06a4a5
Compare
|
All fixed now |
Looks a bit strange when the connection chips places themselves over other data, IMO. Would it be an idea to place them at the bottom of the side nav bar? |
|
Very nice! 
|
|
Could we make it such that pressing the connection chips navigates to the settings page? |
That's the part I don't know how to do just yet |
Could we display a better message here? "Unable to connect to the node: " |
Right, OK. For later! |
This is also a failure case we should pick up, incorrect host |
|
Verify in the input fields that something is entered? |
|
"Reset to config file values" button does nothing? |
|
And when I enter an invalid conf path, nothing happens as well. Would expect something like "file not found" |
No, will fix it in the PR that comes together with persisting custom values to disk |
That's strange, will have to look more at that |
strikes me as a tad bit overkill to add that prefix. the large red glowing globe gives enough context to understand it's an error message imo |
Was more thinking that we should present it as "Unable to connect to the node: Connection refused", and strip away the SocketException stuff. Basically unwrap to the innermost error message, and just display that |
Note that this PR does not persist anything between launches, and changes to the config
settings apply only for the current session.
RPC connections can fail at any time, and before we can implement a nice guide on startup, we need a way to guide them if it fails after they have launched the app.
This implements that UX, with a nice chip in the dashboard indicating connection status. The chip will update when the rpc connection changes.