Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : initial impl custom app drawer folder #5189

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

MrSluffy
Copy link
Member

@MrSluffy MrSluffy commented Jan 21, 2025

Description

  • Initial implementation of app drawer folder (CRUD)
  • Move wallpaper db to preference db

closes :

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

- Initial implementation of app drawer folder (CRUD)
- Move wallpaper db to preference db

closes :
- #4674
- #4710
- #4475
- #3481
@MrSluffy MrSluffy merged commit 95b87da into 15-dev Jan 21, 2025
5 checks passed
@MrSluffy MrSluffy deleted the feat/drawer-allapps branch January 21, 2025 08:15
@SuperDragonXD
Copy link
Collaborator

For transparency purposes, we'll pay MrSluffy $30 — $15 for this PR, and another $15 for #5166

See https://opencollective.com/lawnchair/expenses/235731 for more information.

@imtheabdi
Copy link

For transparency purposes, we'll pay MrSluffy $30 — $15 for this PR, and another $15 for #5166

See https://opencollective.com/lawnchair/expenses/235731 for more information.

great job, @MrSluffy!! the pace of development has been really great recently!

@SuperDragonXD you should make a general discussion and post everything about bounties there.

@SuperDragonXD
Copy link
Collaborator

you should make a general discussion and post everything about bounties there.

Made a pinned discussion at #5191.

@NePoCz
Copy link

NePoCz commented Jan 21, 2025

Hi, great to see this feature implemented, thanks.
I tested the latest dev release and have two comments:
Delete and edit swipes seem to be swapped (oposite to description on screen)
Apps assigned into folders are not hidden on the drawer screen - so they are "copied" into the folder rather than moved

@MrSluffy
Copy link
Member Author

Hi, great to see this feature implemented, thanks. I tested the latest dev release and have two comments: Delete and edit swipes seem to be swapped (oposite to description on screen) Apps assigned into folders are not hidden on the drawer screen - so they are "copied" into the folder rather than moved

done 792d7ed

@pbanj
Copy link

pbanj commented Jan 23, 2025

Just noticed when adding apps to a folder it starts to lock up after about 28. Not sure if it's something on my end or not.
Pixel 8 pro 256gb
Latest evolutionx android 14 build.
Dont have logs as it isnt crashing.

Would it be possible to make it so we can set an icon for the folders?

Big thank you for adding this btw. Now i dont have any cons for this launcher.

@MrSluffy
Copy link
Member Author

Just noticed when adding apps to a folder it starts to lock up after about 28. Not sure if it's something on my end or not. Pixel 8 pro 256gb Latest evolutionx android 14 build. Dont have logs as it isnt crashing.

Would it be possible to make it so we can set an icon for the folders?

Big thank you for adding this btw. Now i dont have any cons for this launcher.

what you mean by

lock up after about 28

@pbanj
Copy link

pbanj commented Jan 23, 2025

Stops responding for a few seconds then asks if i want to close or wait. Clicking wait was allowing it to continue but it would do it every couple after that. I'm still setting them up so if it does it again I'll see if leaving the screen and going back to it fixes it.

@MrSluffy
Copy link
Member Author

Right will check it

@NePoCz
Copy link

NePoCz commented Jan 23, 2025

done 792d7ed

Great, really appreciate the fast response, thanks. Tested the new build and both seem to be fixed. But found two new issues:
When swiping to edit, the name defaults to "My Folder" instead of real name
Changing name directly from the drawer screen does not propagate to the settings screen

nulldrf pushed a commit to nulldrf/lawnchair that referenced this pull request Jan 25, 2025
…uncher#5189)

- Implemented basic CRUD operations for app drawer folders.
- Moved wallpaper database to preference database for better organization.

closes :
- LawnchairLauncher#4674
- LawnchairLauncher#4710
- LawnchairLauncher#4475
- LawnchairLauncher#3481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants