Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed recipes for some hidden Tech Reborn items #484

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

Jellonator
Copy link
Contributor

This PR removes a few recipes for tech reborn items, which were already hidden in REI.

Particularly:

  • Many Tech Reborn plates
  • red garnet dust
  • Silver tools and armors

Plates were particularly removed since their recipes overshadowed some sheet recipes, preventing the use of compressors for producing sheets.

The following (known) recipes were removed:

crafting bench

  • Tech Reborn silver helmet, chestplate, leggings, boots, sword, axe, hoe, pickaxe, and shovel

techreborn:compressor

  • minecraft:gold_ingot -> techreborn:gold_plate
  • minecraft:copper_ingot -> techreborn:copper_plate
  • techreborn:advanced_alloy_ingot -> techreborn:advanced_alloy_plate
  • techreborn:iridium_alloy_ingot -> techreborn:iridium_alloy_plate
  • yttr:yttrium_ingot -> techreborn:iridium_plate
  • techreborn:carbon_mesh -> techreborn:carbon_plate
  • minecraft:emerald_block -> techreborn:emerald_plate
  • minecraft:coal_block -> techreborn:coal_plate
  • minecraft:lapis_block -> techreborn:lapis_plate
  • techreborn:lazurite_dust -> techreborn:lazurite_plate
  • minecraft:obsidian -> techreborn:obsidian_plate
  • create:powdered_obsidian -> techreborn:obsidian_plate
  • minecraft:redstone_block -> techreborn:redstone_plate

techreborn:implosion_compressor

  • techreborn:iridium_alloy_ingot -> techreborn:iridium_alloy_plate
  • techreborn:redstone_block -> techreborn:red_garnet_dust

techreborn:industrial_blast_furnace

  • molten silicon cell -> techreborn:silicon_plate

I discovered a lot of these craftable, yet hidden items by exploring kubejs/client_scripts/hide_from_rei.js. Personally, I think some of this functionality could be merged with removals.js to improve readability and reduce duplication, but this might be beyond my scope in terms of minecraft modding experience.
There may be more items that are hidden but craftable that I am unaware of, and a refactor here might help catch some of these stragglers. Plus, if someone needed to add/remove items from varying mods, they wouldn't have to add it in two separate places.

@Laskyyy Laskyyy merged commit 61fea69 into Laskyyy:Astral-Experimental Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants