[Quest] Implement Fisherman's Heart Quest and supporting tools

[paladindamarus]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

• Implements FIsherman's Heart Quest
• Adds data structures to log fishing history as reported by NPC in Mhaura (Katsunaga)

Steps to test these changes

• Do any amount of fishing and report to Katsunaga in Mhaura
• Katsunaga will not provide stats until the quest is complete. Requires Fishing level 20, min Recruit, and a Gugru Tuna (ID: 4480)
• As you catch fish types, it should be marked with a STAR in the list provided by Katsunaga.
• You can fake catching a fish by self-targeting and using !exec target:setFishCaught(1234, true) (replacing 1234 with the fish ID)

Sources

• Capture discord (captures from Siknoz)
• Custom captures
• Trial / Error on bitmapping using local client

[claywar]

Just for my own sake, can you please rename this enum to FISHERMANS_HEART?

[claywar]

Formatting-wise, return <and/or> newline, then following ones with 4-space indent

[claywar]

simplified: onTrigger = quest:progressEvent(192, xi.item.GUGRU_TUNA),

[claywar]

See above

[claywar]

Haven't gotten there yet, but I'd rather break out if fishing stats are non-existent. updateEvent can take 0 params, so no need to pass an empty table. Also, is this data returned always the same, and could we consolidate it to always return what we need in the format needed?

[paladindamarus]

Good to go on the first part, but I'm not sure I understand the second question? the code for getFishingStats() checks the contents of PChar->m_fishHistory, which is a fixed struct. If the C++ function fails, it returns a table of 0s instead with the same labels.

 local fishingStats = player:getFishingStats()
 if fishingStats ~= nil then
     player:updateEvent({
         [0] = player:getFishingCatchCount() or 0,
         [1] = fishingStats['fishLinesCast'] or 0,
         [2] = fishingStats['fishReeled'] or 0,
         [3] = fishingStats['fishLongestLength'] or 0,
         [4] = fishingStats['fishLongestId'] or 0,
         [5] = fishingStats['fishHeaviestWeight'] or 0,
         [6] = fishingStats['fishHeaviestId'] or 0,
     })
 else
     player:updateEvent(0, 0, 0, 0, 0, 0, 0)
 end

[claywar]

Need to check this datatype to see if it can be simplified, similar to above

[paladindamarus]

The 24-byte bitset (for 196 bits) uses 163 of those bits to build a set of 6 32-bit integers as flags for which fish have been caught. I'm not sure if that's actually the easiest method, but it is how the client receives the data to show "which fish should I put a star next to?"

[zach2good]

The new db system returns rset (result set), the old system returns ret (return code)