review comments 1

LakshSingla · Oct 18, 2023 · 9feb7dc · 9feb7dc
1 parent b2d1401
commit 9feb7dc
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...query/src/main/java/org/apache/druid/msq/querykit/scan/ExternalColumnSelectorFactory.java b/...query/src/main/java/org/apache/druid/msq/querykit/scan/ExternalColumnSelectorFactory.java
@@ -73,6 +73,7 @@ public DimensionSelector makeDimensionSelector(DimensionSpec dimensionSpec)
     return new DimensionSelector()
     {
       final DimensionSelector delegateDimensionSelector = delegate.makeDimensionSelector(dimensionSpec);
+      final ExpressionType expressionType = ExpressionType.fromColumnType(dimensionSpec.getOutputType());
 
       @Override
       public IndexedInts getRow()
@@ -103,7 +104,6 @@ public void inspectRuntimeShape(RuntimeShapeInspector inspector)
       public Object getObject()
       {
         try {
-          ExpressionType expressionType = ExpressionType.fromColumnType(dimensionSpec.getOutputType());
           if (expressionType == null) {
             return delegateDimensionSelector.getObject();
           }
@@ -154,6 +154,9 @@ public ColumnValueSelector makeColumnValueSelector(String columnName)
     return new ColumnValueSelector()
     {
       final ColumnValueSelector delegateColumnValueSelector = delegate.makeColumnValueSelector(columnName);
+      final ExpressionType expressionType = ExpressionType.fromColumnType(
+          rowSignature.getColumnType(columnName).orElse(null)
+      );
 
       @Override
       public double getDouble()
@@ -205,9 +208,6 @@ public boolean isNull()
       public Object getObject()
       {
         try {
-          ExpressionType expressionType = ExpressionType.fromColumnType(rowSignature
-                                                                            .getColumnType(columnName)
-                                                                            .orElse(null));
           if (expressionType == null) {
             return delegateColumnValueSelector.getObject();
           }