Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed blue rat name #139

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Fixed blue rat name #139

merged 2 commits into from
Dec 17, 2023

Conversation

rob-katt
Copy link
Contributor

Resolves #137

Pyrofab
Pyrofab approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@Pyrofab Pyrofab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Pyrofab
Copy link
Member

Pyrofab commented Dec 17, 2023

Maybe you can fix the other localizations while you are at it ?

@rob-katt
Copy link
Contributor Author

You mean removing the old and unused names?

@Pyrofab
Copy link
Member

Pyrofab commented Dec 17, 2023

Well maybe if there are some, but I was more thinking of the other language files

@rob-katt
Copy link
Contributor Author

I didnt find any other language files. I might just be blind

@Pyrofab
Copy link
Member

Pyrofab commented Dec 17, 2023

Huh, true. I guess they were all deleted for 2.0.

@rob-katt
Copy link
Contributor Author

I also noticed that remy didnt have a translation and that Jorato, Hollow, Rateline and Arathain are no longer in the game, so i fixed those to

@Pyrofab
Copy link
Member

Pyrofab commented Dec 17, 2023

Sounds good to me

@Pyrofab Pyrofab merged commit 88980b4 into Ladysnake:main Dec 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pyrofab Pyrofab Pyrofab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rat pouch bug
2 participants
@rob-katt @Pyrofab