Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add german translation 'de_de.json' #36

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tristankechlo
Copy link

@tristankechlo tristankechlo commented Mar 13, 2024

  • adds a new translation file for the german language

if you want to, I can also open PR's for the other branches/versions

Copy link
Contributor

@Xiribidus Xiribidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully satisfied due to some misleading things here and there, death msgs are difficult to translate too

src/main/resources/assets/pickyourpoison/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/pickyourpoison/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/pickyourpoison/lang/de_de.json Outdated Show resolved Hide resolved
"item.pickyourpoison.stimulation_poison_dart": "Vergifteter Pfeil",
"item.pickyourpoison.blindness_poison_dart": "Vergifteter Pfeil",
"effect.pickyourpoison.batrachotoxin": "Batrachotoxin",
"effect.pickyourpoison.comatose": "Betäubung",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "Lähmung" be more fitting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose Betäubung, because Lähmung sounded a lot more of a permanent thing to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lähmung can also be non permanent and does reflect the severity of the effect quite well though. Ig either works, maybe someone else also has a different suggestion

"effect.pickyourpoison.comatose": "Betäubung",
"effect.pickyourpoison.vulnerability": "Verletzlichkeit",
"effect.pickyourpoison.numbness": "Benommenheit",
"effect.pickyourpoison.torpor": "Erstarrung",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a little misleading, any other ideas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically made me think it was comatose at first

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's what torpor is translated to, the next best translation would be Trägheit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what it does, maybe Unheilbar would be an alternative

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do prefer Trägheit, I don't think Erstarrung really works in this context, again, maybe someone else has a different idea

src/main/resources/assets/pickyourpoison/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/pickyourpoison/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/pickyourpoison/lang/de_de.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants