LibWeb: Improve html/body size quirks #3271
Open
+829
−638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psychpsyo
force-pushed
the
quirks-for-html-body
branch
from
cfbfd0a to
09c42a3
Compare
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
Psychpsyo
force-pushed
the
quirks-for-html-body
branch
from
09c42a3 to
f673230
Compare
github-actions
bot
removed
the
conflicts
Psychpsyo
force-pushed
the
quirks-for-html-body
branch
from
f673230 to
56b26db
Compare
Psychpsyo
force-pushed
the
quirks-for-html-body
branch
from
56b26db to
6a8912c
Compare
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves our behavior for the The html element fills the viewport quirk and the The body element fills the html element quirk from the Quirks Mode Standard
It also removes
PaintableFragment::orientation()since that is now handled on layout nodes. (Node::text_flow_direction())I've had to rebaseline quite a few layout tests since they did not have an html doctype set and were therefore using quirks mode.
Ideally, these should probably just not run under quirks mode, but that is like an hour of copying
<!DOCTYPE html>declarations everywhere...But maybe I'll do some of that before this gets reviewed.