LibWeb: Resolve SVGImageElement source URL correctly

This fixes an issue where an SVGImageElement, whose source was a relative URL would not load inside an iframe.
LadybirdBrowser · Jan 19, 2025 · 400aefb · 400aefb
1 parent b7512de
commit 400aefb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/Libraries/LibWeb/SVG/SVGImageElement.cpp b/Libraries/LibWeb/SVG/SVGImageElement.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024, Tim Ledbetter <[email protected]>
+ * Copyright (c) 2024-2025, Tim Ledbetter <[email protected]>
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -140,7 +140,13 @@ Gfx::Rect<CSSPixels> SVGImageElement::bounding_box() const
 // https://www.w3.org/TR/SVG2/linking.html#processingURL
 void SVGImageElement::process_the_url(Optional<String> const& href)
 {
-    m_href = document().url().complete_url(href.value_or(String {}));
+    if (!href.has_value()) {
+        m_href = {};
+        return;
+    }
+
+    m_href = document().parse_url(*href);
+
     if (!m_href.is_valid())
         return;
 

diff --git a/Tests/LibWeb/Ref/expected/svg-image-in-iframe-ref.html b/Tests/LibWeb/Ref/expected/svg-image-in-iframe-ref.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<iframe srcdoc="<svg xmlns='http://www.w3.org/2000/svg'><rect width='150' height='100' fill='green' /></svg>"></iframe>
diff --git a/Tests/LibWeb/Ref/input/svg-image-in-iframe.html b/Tests/LibWeb/Ref/input/svg-image-in-iframe.html
@@ -0,0 +1,3 @@
+<!DOCTYPE html>
+<link rel="match" href="../expected/svg-image-in-iframe-ref.html" />
+<iframe srcdoc="<svg xmlns='http://www.w3.org/2000/svg'><image href='../data/rectangle.png' width='150' height='100' /></svg>"></iframe>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		<!DOCTYPE html>
		<iframe srcdoc="<svg xmlns='http://www.w3.org/2000/svg'><rect width='150' height='100' fill='green' /></svg>"></iframe>