update ciphers to match latest ALB policy #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The default cipher suite is outdated. This updates available cipher suites to match AWS's
ELBSecurityPolicy-TLS13-1-2-2021-06, but is still compatible with at leastELBSecurityPolicy-TLS-1-2-2017-01, and maybe more. This makes it more secure than tomcat's default set.Also, the default application.properties file has long contained environment variables set up for bash expansion, but was not processed in a way that would take advantage of that. This update shifts default values to Dockerfile env, then adds config/application.properties to the envsubst block in entrypoint.sh, such that the final file has proper values (including the new cipher suite).
Related Pull Requests
Changes