Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build Wheel fixes #29

Merged
merged 2 commits into from
Dec 18, 2023
Merged

CI Build Wheel fixes #29

merged 2 commits into from
Dec 18, 2023

Conversation

billbrod
Copy link
Member

@billbrod billbrod commented Dec 18, 2023

Two small changes:

  • Fix failing CIBW builds: they were failing because the path for the tests were wrong (see docs)
  • Adds cross-compilation support (see docs), which builds wheels for the new M2 Macs.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (801c47f) 69.72% compared to head (3f75a17) 69.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          19       19           
  Lines        1460     1460           
  Branches      328      328           
=======================================
  Hits         1018     1018           
  Misses        348      348           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@billbrod billbrod changed the title Fixes path for CIBW_TEST_COMMAND CI Build Wheel fixes Dec 18, 2023
@billbrod billbrod merged commit 83125b0 into main Dec 18, 2023
38 checks passed
@billbrod billbrod deleted the cibw_test_fix branch December 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant