Avoid issues with subsetting via do.call, fixes #32.

LTLA · May 25, 2022 · 51f8b0b · 51f8b0b
1 parent d366583
commit 51f8b0b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: batchelor
-Version: 1.13.0
-Date: 2021-08-11
+Version: 1.13.1
+Date: 2022-05-25
 Title: Single-Cell Batch Correction Methods
 Authors@R: c(person("Aaron", "Lun", role = c("aut", "cre"), email = "[email protected]"),
     person("Laleh", "Haghverdi", role="ctb"))

diff --git a/R/correctExperiments.R b/R/correctExperiments.R
@@ -98,7 +98,9 @@ correctExperiments <- function(..., batch=NULL, restrict=NULL, subset.row=NULL,
     for (nm in combine.assays) {
         raw.ass <- lapply(x, assay, i=nm)
         if (!is.null(subset.row) && !correct.all) {
-            raw.ass <- lapply(raw.ass, "[", i=subset.row, , drop=FALSE)
+            for (i in seq_along(raw.ass)) {
+                raw.ass[[i]] <- raw.ass[[i]][subset.row,,drop=FALSE]
+            }
         }
         assay(merged, nm) <- do.call(cbind, raw.ass)
     }