add mask replacement of nan and negative mag errors #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17 where Henrique was having problems because data contains np.nan for magnitudes and magnitude errors, and any magnitude errors that are <=0.0 (GPz by default takes the log of the errors). This adds a simple mask check to the data processing to get rid of those values. It also adds a new parameter where you can set the value to replace the negative magnitude errors with in each band. I tested this on some data where I replaces inputs so that they had some NaNs and negative mag errors and all were caught and replaced.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added