Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new notebook for quality control #168

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yanzastro
Copy link

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@yanzastro yanzastro linked an issue Nov 26, 2024 that may be closed by this pull request
3 tasks
@yanzastro yanzastro requested a review from aimalz November 26, 2024 16:16
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (75f52e8) to head (e548d2a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanzastro yanzastro changed the title add_new_notebook add a new notebook for quality control Dec 2, 2024
@ztq1996
Copy link
Contributor

ztq1996 commented Dec 2, 2024

The smoke test is passed, so that's good.

One question: is it your intention to change the BPZ notebook? I see that the run number is changed. If not, can you roll back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the somocluSOMcluster_demo.ipynb notebook for quality control
2 participants