added DESCQAGEN directory to DESCQA #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this PR is merged, it will close #44 |
|
@duncandc is this PR up-to-date and ready to be reviewed? |
|
@yymao I think this can now be merged. |
yymao
requested changes
Jun 7, 2018
|
|
||
| if sys.argv[1] == 'data': | ||
| sql_file = PROJECT_DIRECTORY + 'sql/hsc_data.sql' | ||
| savename = DATA_DIRECTORY + 'hsc_data.csv' |
There was a problem hiding this comment.
savename is not used in the following script. Is this intended?
There was a problem hiding this comment.
hmmm, I dont see where the filename that is used to save the data is specified... let me try to reload this into my memory...
There was a problem hiding this comment.
Just a gentle reminder: @duncandc any luck on solving this minor issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request begins a section of DESCQA called DESCQAGEN which serves as a repo for the code and analysis that generates the validation test data.
To get things started, I have included the code I used to create the apparent magnitude function test using HSC data with a lot of help from @rmandelb.
[Edited by @yymao: This PR fixes #44]