Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stem method #65

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

added stem method #65

wants to merge 3 commits into from

Conversation

fjaviersanchez
Copy link
Collaborator

This PR adds the stem derivative method as implemented by @nikosarcevic. For now, it is pretty barebones/non-optimized. Will be working on improving speed in the upcoming days.

@fjaviersanchez
Copy link
Collaborator Author

fjaviersanchez commented Jul 9, 2024

Will need to update the environment and install instructions to make this work. For reference, how I use it locally:

git clone [email protected]:nikosarcevic/Derivative-Calculator.git
ipython
import sys
sys.path.append('PATH-to-Derivative-Calculator')
from augur.analyze import Analyze
ao = Analyze('./examples/config_test.yaml')
ao.get_fisher_matrix(method='stem')

Note that this is currently very slow with the default number of parameters (12+ hours in my laptop).

@arthurmloureiro
Copy link
Collaborator

Will need to update the environment and install instructions to make this work. For reference, how I use it locally:

git clone [email protected]:nikosarcevic/Derivative-Calculator.git
ipython
import sys
sys.path.append('PATH-to-Derivative-Calculator')
from augur.analyze import Analyze
ao = Analyze('./examples/config_test.yaml')
ao.get_fisher_matrix(method='stem')

Note that this is currently very slow with the default number of parameters (12+ hours in my laptop).

Hi @fjaviersanchez !
I think we should avoid having to import more paths into augur.

Maybe we can ask @nikosarcevic if this derivative calculations can be packaged into pip or at least have a pip installable option?* Or maybe if @nikosarcevic can include her derivatives into augur?

  • I see there's a PR already here which addresses this question. Maybe we should hold-on until it is merged so we can make the derivatives an easier dependency on augur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants