added more flexible binning #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosggarcia, please feel free to assign someone else as a reviewer!! |
carlosggarcia
requested changes
Jul 7, 2024
|
thanks! I think that the unit tests are broken. I am thinking it could be some issue with NaMaster's versions. I can open a separate PR to try to fix them and then rebase because it doesn't allow me to merge as is :( |
|
Actually it looks like that! Pinging @damonge. I think we can merge this since the tests passed in my laptop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of us have discussed online the possibility of adding more flexible binning for the covariance calculation using TJPCov, for example, reading bandpower windows. Here's a first draft implementation for that.