Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOM + RESSPECT end to end testing #81

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

TOM + RESSPECT end to end testing #81

wants to merge 7 commits into from

Conversation

mtauraso
Copy link
Collaborator

@mtauraso mtauraso commented Nov 20, 2024 •
edited
Loading

A github actions script that reproducibly launches TOM + Resspect docker env.

Pair coded parts with @AmandaWasserman

History has been re-written to remove several debugging steps with GHA.

@mtauraso mtauraso marked this pull request as ready for review November 20, 2024 20:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Before [cd86501] After [b8c7efb] Ratio Benchmark (Parameter)
162±3ms 164±1ms 1.01 benchmarks.time_learn_loop('KNN', 'RandomSampling')
165±1ms 166±1ms 1.01 benchmarks.time_learn_loop('KNN', 'UncSampling')
192M 192M 1 benchmarks.peakmem_learn_loop('KNN')
196M 196M 1 benchmarks.peakmem_learn_loop('RandomForest')
3.12±0s 3.12±0s 1 benchmarks.time_learn_loop('RandomForest', 'UncSampling')
3.14±0.02s 3.12±0.01s 0.99 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
139±1ms 135±2ms 0.97 benchmarks.time_feature_creation

Click here to view all benchmarks.

@mtauraso mtauraso self-assigned this Nov 20, 2024
@mtauraso mtauraso force-pushed the compose-tom branch 3 times, most recently from bf017ab to 099a60c Compare November 27, 2024 19:38
@mtauraso
First try at tom + resspect GHA
06faf50
@mtauraso
Adding a version of tom test that works locally.
c9b48df 
- Bootstrap test/train/validate features
- Bind mounting of a work dir in dockerfile
- Test scripts to run one night of training
- Compose configuration to work with TOM
- Github action script to run full flow int TOM test env

Pair coded with @AmandaWasserman
@mtauraso
Initial Code Review fixups
e9ace58
@mtauraso
Set up example results directory
141445e 
- Bind mount in the compose env, ignoring appropriate files such that
- Empty results dir in the bare container for functionality
@mtauraso
Make file write behavior for metrics and queried_sample match documen…
bde9221 
…tation.
@mtauraso
Minimal Fixup to Pandas Dataframe pool_labels bug
6ecc6f2
@mtauraso mtauraso changed the title First try at tom + resspect GHA TOM + RESSPECT end to end testing Dec 11, 2024
drewoldag
drewoldag approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Thanks for tackling the .to_numpy() issue in database.py!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

@rknop rknop Awaiting requested review from rknop

@AmandaWasserman AmandaWasserman Awaiting requested review from AmandaWasserman

Assignees

@mtauraso mtauraso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtauraso @drewoldag