Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM10-cosmoDC2 lensed AGN systems #75

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

padma18-vb
Copy link
Collaborator

@padma18-vb padma18-vb commented Oct 5, 2023

Starting a PR for OM10 lens + cosmoDC2 host galaxies. This is still a work in progress and not ready for review!

So far:

  • I've added some initial skeleton files under Sources and Deflectors.
  • I've added the OM10-cosmoDC2 catalog of quasars and galaxy lens systems.
  • I'm currently running tests to validate number of images we see + image positions
  • I've added SimAPI based point source + extended source functionality
  • I'm yet to add the analysis notebook for OM10 lens systems (parallel to galaxy-galaxy lensing tutorial notebook); I will add this once I add more informative notes

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: Patch coverage is 2.40550% with 284 lines in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (5c535f3) to head (5ca4237).

Files with missing lines Patch % Lines
slsim/om10_cosmodc2_lens.py 0.00% 202 Missing ⚠️
slsim/om10_cosmodc2_lens_pop.py 0.00% 33 Missing ⚠️
slsim/Pipelines/catalog_pipeline.py 0.00% 16 Missing ⚠️
slsim/Deflectors/om10_lens_galaxies.py 0.00% 11 Missing ⚠️
slsim/Sources/cosmoDC2AGN.py 0.00% 11 Missing ⚠️
slsim/image_simulation.py 8.33% 11 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5c535f3) and HEAD (5ca4237). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (5c535f3) HEAD (5ca4237)
6 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   97.90%   92.28%   -5.62%     
==========================================
  Files          70       75       +5     
  Lines        4675     4965     +290     
==========================================
+ Hits         4577     4582       +5     
- Misses         98      383     +285     
Files with missing lines Coverage Δ
slsim/Deflectors/deflectors_base.py 85.71% <ø> (ø)
slsim/Util/param_util.py 100.00% <100.00%> (ø)
slsim/Deflectors/om10_lens_galaxies.py 0.00% <0.00%> (ø)
slsim/Sources/cosmoDC2AGN.py 0.00% <0.00%> (ø)
slsim/image_simulation.py 93.25% <8.33%> (-6.75%) ⬇️
slsim/Pipelines/catalog_pipeline.py 0.00% <0.00%> (ø)
slsim/om10_cosmodc2_lens_pop.py 0.00% <0.00%> (ø)
slsim/om10_cosmodc2_lens.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant