Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include a magnification limit to remove highly de-magnified images #59

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

sibirrer
Copy link
Contributor

This PR adds the option to not include highly de-magnified images in the image position catalogue. While this most likely does not change any appearances in the simulation of images, it can affect the image catalogue and reflects more closely observable images.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #59 (5720c97) into main (3aaafb4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 5720c97 differs from pull request most recent head 1018672. Consider uploading reports for the commit 1018672 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   72.94%   72.97%   +0.03%     
==========================================
  Files          19       19              
  Lines         850      851       +1     
==========================================
+ Hits          620      621       +1     
  Misses        230      230              
Files Changed Coverage Δ
sim_pipeline/galaxy_galaxy_lens.py 83.72% <100.00%> (+0.07%) ⬆️

@sibirrer sibirrer changed the base branch from main to agn_sources September 13, 2023 13:39
@sibirrer sibirrer merged commit 6068382 into LSST-strong-lensing:agn_sources Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants