More robust for LOS #285
Merged
More robust for LOS #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add LOSConfigParams so when LensPop rendering population, will got different LOSConfig class. 2. delete the invalid input of mixgauss_means....
This reverts commit 09283f7.
1. add LOSConfigParams so when LensPop rendering population, will got different LOSConfig class. 2. delete the invalid input of mixgauss_means....
1.Simply change on los_config.py 2.delete the invalid input of mixgauss_means in Lens....
z_source <= z_lens still can be passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 97.69% 97.67% -0.02%
==========================================
Files 74 74
Lines 4952 4954 +2
==========================================
+ Hits 4838 4839 +1
- Misses 114 115 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if z_source <= z_lens, LOS can still be passed.