-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to convert MJD time to days for transient events. #280
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 97.73% 97.69% -0.04%
==========================================
Files 74 74
Lines 4946 4952 +6
==========================================
+ Hits 4834 4838 +4
- Misses 112 114 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nkhadka21! I have a request for re-naming what you called zero_point. Otherwise is looking good. Would be great if you could also update/add a notebook with an OpSimSummary created light curve with a pre-defined event time
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @sibirrer, I changed the name you suggested and also added a notebook showing use of opsim_pipeline. |
No description provided.