Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to convert MJD time to days for transient events. #280

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

nkhadka21
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (620da6e) to head (6e309c0).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   97.73%   97.69%   -0.04%     
==========================================
  Files          74       74              
  Lines        4946     4952       +6     
==========================================
+ Hits         4834     4838       +4     
- Misses        112      114       +2     
Files with missing lines Coverage Δ
slsim/LsstSciencePipeline/util_lsst.py 83.63% <100.00%> (ø)
slsim/Util/param_util.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@nkhadka21 nkhadka21 requested a review from sibirrer November 18, 2024 19:53
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nkhadka21! I have a request for re-naming what you called zero_point. Otherwise is looking good. Would be great if you could also update/add a notebook with an OpSimSummary created light curve with a pre-defined event time

slsim/Util/param_util.py Outdated Show resolved Hide resolved
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nkhadka21
Copy link
Collaborator Author

Hi @sibirrer, I changed the name you suggested and also added a notebook showing use of opsim_pipeline.

@nkhadka21 nkhadka21 merged commit 62d52f7 into LSST-strong-lensing:main Nov 19, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants