Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive routine #273

Merged
merged 33 commits into from
Nov 14, 2024
Merged

Conversation

nkhadka21
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.46%. Comparing base (5cc87c5) to head (d69b6db).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
slsim/FalsePositives/false_positive_pop.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   97.39%   97.46%   +0.07%     
==========================================
  Files          71       72       +1     
  Lines        4873     4860      -13     
==========================================
- Hits         4746     4737       -9     
+ Misses        127      123       -4     
Files with missing lines Coverage Δ
slsim/Deflectors/all_lens_galaxies.py 100.00% <100.00%> (ø)
slsim/Deflectors/cluster_deflectors.py 100.00% <100.00%> (ø)
slsim/Deflectors/compound_lens_halos_galaxies.py 100.00% <100.00%> (ø)
slsim/Deflectors/elliptical_lens_galaxies.py 95.08% <100.00%> (+0.16%) ⬆️
slsim/FalsePositives/false_positive.py 100.00% <100.00%> (ø)
slsim/Sources/galaxies.py 99.32% <100.00%> (+0.03%) ⬆️
slsim/Sources/point_plus_extended_sources.py 100.00% <ø> (ø)
slsim/Sources/point_sources.py 92.85% <100.00%> (+0.54%) ⬆️
slsim/Sources/source_pop_base.py 90.62% <100.00%> (+1.73%) ⬆️
slsim/lens_pop.py 100.00% <100.00%> (ø)
... and 2 more

... and 4 files with indirect coverage changes

@nkhadka21 nkhadka21 marked this pull request as ready for review November 12, 2024 19:46
@nkhadka21 nkhadka21 requested a review from sibirrer November 12, 2024 19:47
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nkhadka21. I have some requests and comments about documentation and structure.

slsim/FalsePositives/false_positive.py Outdated Show resolved Hide resolved
slsim/FalsePositives/false_positive_pop.py Show resolved Hide resolved
slsim/FalsePositives/false_positive_pop.py Show resolved Hide resolved
slsim/Sources/galaxies.py Show resolved Hide resolved
@nkhadka21 nkhadka21 requested a review from sibirrer November 13, 2024 00:14
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Now, that's a bit more clear to me, I have some other suggestions to make the code a bit more streamlined.

slsim/FalsePositives/false_positive_pop.py Outdated Show resolved Hide resolved
slsim/FalsePositives/false_positive_pop.py Outdated Show resolved Hide resolved
slsim/FalsePositives/false_positive_pop.py Show resolved Hide resolved
slsim/FalsePositives/false_positive_pop.py Outdated Show resolved Hide resolved
slsim/FalsePositives/false_positive_pop.py Outdated Show resolved Hide resolved
@nkhadka21 nkhadka21 requested a review from sibirrer November 14, 2024 21:12
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much!

@nkhadka21 nkhadka21 merged commit d5b01a4 into LSST-strong-lensing:main Nov 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants