Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix CI #322

Merged
merged 3 commits into from
Jan 6, 2022
Merged

nix CI #322

merged 3 commits into from
Jan 6, 2022

Conversation

bgregoir
Copy link
Collaborator

@bgregoir bgregoir commented Jan 6, 2022

With Cyril help's

@eponier
Copy link
Collaborator

eponier commented Jan 6, 2022

We discussed with @CohenCyril about how to use coq-nix-toolbox to both have nix-shell and ci. This PR is a proof of concept.

@CohenCyril explained that by default there is no caching. If we want some, we would have to ask for an access for Coq's cache or create our own account elpi/coq-elpi on Cachix. We can also disable the test of reverse dependencies if we find it too costly.

@CohenCyril
Copy link
Collaborator

@Zimmi48 could we make room for a LPCIC cache in the coq cachix organization?

@eponier
Copy link
Collaborator

eponier commented Jan 6, 2022

@gares To be fair w.r.t. Cyril's work, the effort was pretty small. It was basically a matter of following https://github.com/coq-community/coq-nix-toolbox#standalone. With Cyril's help, it was straightforward. But it may become more complex for more advanced stuff, I don't know.

@gares
Copy link
Contributor

gares commented Jan 6, 2022

Fine with nix, but please don't remove the other workflows. One builds the doc, which I don't think nix does.
The other is probably subsumed by nix.

@gares
Copy link
Contributor

gares commented Jan 6, 2022

I did the fix myself, if it works I'll merge

@gares gares changed the title Test ci nix CI Jan 6, 2022
@gares gares merged commit 2cdb66c into master Jan 6, 2022
@gares gares deleted the test-ci branch January 6, 2022 18:32
@Zimmi48
Copy link
Contributor

Zimmi48 commented Jan 7, 2022

Sure, we can add @gares to the "Coq ecosystem" Cachix organization. Please contact me by private message on Zulip.

@gares
Copy link
Contributor

gares commented Jan 10, 2022

@CohenCyril why don't you become an admin of this repo and set up cachix?

@CohenCyril
Copy link
Collaborator

@CohenCyril why don't you become an admin of this repo and set up cachix?

Sure admin me

@gares
Copy link
Contributor

gares commented Jan 10, 2022

Apparently there is a "maintainer" role, but I could not understand if you can create secrets (it seems so, but the doc is not clear to me). Please try, if not I'll admin you.

@CohenCyril
Copy link
Collaborator

CohenCyril commented Jan 10, 2022

@gares I do not have access to secrets as of now.

@gares
Copy link
Contributor

gares commented Jan 10, 2022

ok, now you are Admin.

@CohenCyril CohenCyril mentioned this pull request Jan 11, 2022
Copy link
Collaborator

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gares to reactivate rev dep test on HB for example
cf #334

## You can override Coq and other Coq coqPackages
## through the following attribute
coqPackages.coq.override.version = "8.15";
#coqPackages.hierarchy-builder.job = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gares

Suggested change
#coqPackages.hierarchy-builder.job = false;
coqPackages.hierarchy-builder.override.version = "master";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants