UseVfsMixin: add vf_trust parameter

[jtluka]

Description

This adds vf_trust parameter to UseVfsMixin. The Device class is extended with vf_trust() method.

Tests

J:9865704 J:9939392

Note that sfc driver tests failed because the device does not support vf_trust. I have a separate patch set that fixes that along with different way to achieve same functionality.

Reviews

@olichtne

[jtluka]

As they're not both boolean, I'll update the dosctring.

[olichtne]

the docstring still says "two boolean parameters"

[jtluka]

Hmm, so I think I've accidentally originally pushed the code to LNST-project's git tree instead of my fork. Then I pushed the updates into my fork's git, so they're not visible here. I'll fix that.

[jtluka]

There is no way to change the source branch of PR, I created a new one in #381

[jtluka]

This is fixed in new PR.

[jtluka]

I noticed that there's a flaw in the implementation:

    Testwide configuration for recipe VlansOverBondRecipe description:
    Using vf device enp2s0f0v0 of pf enp2s0f0 for DeviceReq host1.eth0 trusted={self.params.vf_trust}
    Using vf device enp2s0f1v0 of pf enp2s0f1 for DeviceReq host1.eth1 trusted={self.params.vf_trust}
    Using vf device enp2s0f0v0 of pf enp2s0f0 for DeviceReq host2.eth0 trusted={self.params.vf_trust}

For this recipe we need to set vf trust only on host1 that configures the bond device. The other host does not use bonding so it is not necessary to configure vf trust.

[jtluka]

I noticed that there's a flaw in the implementation:

    Testwide configuration for recipe VlansOverBondRecipe description:
    Using vf device enp2s0f0v0 of pf enp2s0f0 for DeviceReq host1.eth0 trusted={self.params.vf_trust}
    Using vf device enp2s0f1v0 of pf enp2s0f1 for DeviceReq host1.eth1 trusted={self.params.vf_trust}
    Using vf device enp2s0f0v0 of pf enp2s0f0 for DeviceReq host2.eth0 trusted={self.params.vf_trust}

For this recipe we need to set vf trust only on host1 that configures the bond device. The other host does not use bonding so it is not necessary to configure vf trust.

Fixed by adding vf_trust_device_list property.

[olichtne]

this directly prints self.params... is there maybe also a getter for the Device.vf_trust value that should be used instead to reflect the real state of the device?

[jtluka]

There's no getter atm. The "property" is implemented through a method. Maybe I could change this to property.

[olichtne]

minor questions asked. but overall looks ok