-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerPoolManager: add netavark support #378
Conversation
I will update the container documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor comment, otherwise this looks ok.
not sure if github ci needs to be (or should be) somehow updated as that also runs tests in a container environment.
I expected some issues with CI and I will take a look at it. |
683ec51
to
411c868
Compare
I've added automatic detection of network backend, so updates to github CI should not be necessary. |
CI will require the patch anyway. I've tested automatic backend detection on Fedora39 + cni and container setup works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me now.
Signed-off-by: Jan Tluka <[email protected]>
Signed-off-by: Jan Tluka <[email protected]>
cb65b76
to
ddadc1f
Compare
Description
With podman5+ the CNI network backend support is removed, with netavark being the default network plugin.
This adds support for netavark network backend and changes the ContainerPoolManager to use it as default.
The CNI backend support is kept and user can force LNST to use it by
ContainerPoolManager(network_plugin='cni')
.Tests
Tested on Fedora40 with podman-5.2.2-1.fc40.x86_64
Reviews
@olichtne @enhaut