Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerPoolManager: add netavark support #378

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

jtluka
Copy link
Collaborator

@jtluka jtluka commented Sep 16, 2024

Description

With podman5+ the CNI network backend support is removed, with netavark being the default network plugin.

This adds support for netavark network backend and changes the ContainerPoolManager to use it as default.

The CNI backend support is kept and user can force LNST to use it by ContainerPoolManager(network_plugin='cni').

Tests

Tested on Fedora40 with podman-5.2.2-1.fc40.x86_64

Reviews

@olichtne @enhaut

@jtluka jtluka requested review from enhaut and olichtne September 16, 2024 11:29
@jtluka
Copy link
Collaborator Author

jtluka commented Sep 16, 2024

I will update the container documentation.

Copy link
Collaborator

@olichtne olichtne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment, otherwise this looks ok.

not sure if github ci needs to be (or should be) somehow updated as that also runs tests in a container environment.

lnst/Controller/ContainerPoolManager.py Outdated Show resolved Hide resolved
@jtluka
Copy link
Collaborator Author

jtluka commented Sep 16, 2024

just a minor comment, otherwise this looks ok.

not sure if github ci needs to be (or should be) somehow updated as that also runs tests in a container environment.

I expected some issues with CI and I will take a look at it.

@jtluka jtluka force-pushed the containers-netavark branch 2 times, most recently from 683ec51 to 411c868 Compare September 16, 2024 16:59
@jtluka
Copy link
Collaborator Author

jtluka commented Sep 16, 2024

I've added automatic detection of network backend, so updates to github CI should not be necessary.

@jtluka
Copy link
Collaborator Author

jtluka commented Sep 16, 2024

CI will require the patch anyway.

I've tested automatic backend detection on Fedora39 + cni and container setup works fine.

@jtluka jtluka requested review from olichtne and enhaut September 16, 2024 17:37
olichtne
olichtne previously approved these changes Sep 17, 2024
Copy link
Collaborator

@olichtne olichtne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me now.

@jtluka jtluka merged commit de79872 into LNST-project:master Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants