External.TRex.UDPSimple: use src/dst mac and ip addresses #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default trex packet stream generator didn't correctly use the provided source and destination ip and mac addresses. This wasn't noticed until now because the test is typically run in a lab where multiple machine pairs were isolated from eachother. This however isn't MANDATORY and so to avoid conflicts on a shared network we should respect the provided values. Signed-off-by: Ondrej Lichtner <[email protected]>
jtluka
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default trex packet stream generator didn't correctly use the provided source and destination ip and mac addresses.
This wasn't noticed until now because the test is typically run in a lab where multiple machine pairs were isolated from eachother.
This however isn't MANDATORY and so to avoid conflicts on a shared network we should respect the provided values.
Tests
(Please provide a list of tests that prove that the pull
request doesn't break the stable state of the master branch. This should
include test runs with valid results for all of critical workflows.)
Reviews
(Please add a list of reviewers that should check the validity and sanity of
this merge request before it's accepted. Use the
@usernamesyntax. If youdon't know who to mention just link
@all.)Closes: #