Skip to content

Commit

Permalink
Perf.Measurements.TcRunMeasurement: remove run_success
Browse files Browse the repository at this point in the history
This is equivalent to the measurement_success so this is no longer
needed.

Signed-off-by: Ondrej Lichtner <[email protected]>
  • Loading branch information
olichtne committed Nov 20, 2024
1 parent e097351 commit e8cf628
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ def rule_install_rate(self) -> SequentialPerfResult:
def rule_install_rate(self, result: SequentialPerfResult):
self._rule_install_rate = result

@property
def run_success(self) -> bool:
return all((i.run_success for i in self.individual_results))

@property
def individual_results(self) -> list[TcRunMeasurementResults]:
return self._individual_results
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def __init__(
super().__init__(measurement, measurement_success, warmup_rules)
self._device = device
self._rule_install_rate: ParallelPerfResult = None
self._run_success: bool = None

@property
def metrics(self) -> list[str]:
Expand All @@ -39,14 +38,6 @@ def rule_install_rate(self) -> ParallelPerfResult:
def rule_install_rate(self, result: ParallelPerfResult):
self._rule_install_rate = result

@property
def run_success(self) -> bool:
return self._run_success

@run_success.setter
def run_success(self, v: bool):
self._run_success = v

@property
def description(self):
return f"{self.device.host.hostid}.{self.device.name}" \
Expand Down
1 change: 0 additions & 1 deletion lnst/RecipeCommon/Perf/Measurements/TcRunMeasurement.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ def collect_results(self) -> list[TcRunMeasurementResults]:
run_result.rule_install_rate = ParallelPerfResult(
[self._get_instance_interval(d) for d in instance_data]
)
run_result.run_success = job.passed

return [run_result]

Expand Down

0 comments on commit e8cf628

Please sign in to comment.