Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] Fix crash due to no-connectivity #346

Closed
wants to merge 3 commits into from
Closed

[WIP] Fix crash due to no-connectivity #346

wants to merge 3 commits into from

Conversation

mdb1
Copy link

@mdb1 mdb1 commented Sep 16, 2020

Description

Fix crash when creating a wallet on airplane mode

Motivation and Context

Fixes #236

How Has This Been Tested?

The fix is not completed yet, we need 2 things to advance:

  1. How do we want the "No internet" view controller to look like? I was thinking maybe an image with 2 texts (title and description) and a CTA on the bottom. Something like:
    [Image]
    Something went wrong
    Seems like you are not connected to the internet
    [TRY AGAIN]
  2. What should we do with iOS versions < 12?

Screenshots (if appropriate):

Will add when I code the new error screen

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

Codecov Report

Merging #346 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #346      +/-   ##
=========================================
- Coverage    6.68%   6.67%   -0.01%     
=========================================
  Files         233     234       +1     
  Lines        8259    8271      +12     
=========================================
  Hits          552     552              
- Misses       7707    7719      +12     
Impacted Files Coverage Δ
Library/Helper/NetworkConnection.swift 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf40a5...f888a0e. Read the comment docs.

@mdb1 mdb1 closed this Nov 19, 2020
@mdb1 mdb1 deleted the connectivity branch November 19, 2020 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when launched in airplane (offline) mode
2 participants