This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Payments authentication toggle setting #340
Open
Jeiwan
wants to merge
10
commits into
LN-Zap:master
Choose a base branch
from
Jeiwan:payments_pin_protection_setting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeiwan
changed the title
Payments PIN protection setting
Payments authentication toggle setting
May 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
- Coverage 10.27% 6.54% -3.74%
=========================================
Files 245 234 -11
Lines 8629 8330 -299
=========================================
- Hits 887 545 -342
- Misses 7742 7785 +43
Continue to review full report at Codecov.
|
That coverage report is wrong, I didn't change anything in BlockChainHeightUpdater.swift. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #269
Description
This PR adds a new setting: Authenticate payments. It's on by default and, when switched off, payments don't require authentication (no need to type PIN or scan biometrics). For security reasons, switching it off requires authentication.
Motivation and Context
Sending many payments can be annoying because each of them requires a PIN or a biometrics scan. Users can opt out of authenticating every payment.
How Has This Been Tested?
Tested in a simulator connected to Simnet. Sent multiple payments with 'Authenticate payments' setting on and off and with fake biometrics authentication on and off .
Screenshots (if appropriate):
Types of changes
Checklist: