Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callsites output #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix callsites output #14

wants to merge 1 commit into from

Conversation

artpol84
Copy link
Contributor

No description provided.

@artpol84
Copy link
Contributor Author

This PR depends on #11 to avoid conflicts.

@artpol84 artpol84 mentioned this pull request Jun 26, 2019
Closed
@artpol84
Copy link
Contributor Author

Will rebase ASAP as indentation PR is in

@artpol84 artpol84 force-pushed the fix/callsites_output branch from 5a22361 to 3a6c1d3 Compare June 27, 2019 22:20
@artpol84
Copy link
Contributor Author

@cchambreau, rebased

@artpol84
Fix the callsite report
4eda0b2 
Use the MPI operation name as an indicator of the starting point of
a callsite.
We know that MPI_<op> is located in the wrappers.c (or maybe in another
profiler's wrapper file).
So we only output callsite starting from frames above the one, containing
MPI_<op>

Signed-off-by: Artem Polyakov <[email protected]>
@artpol84 artpol84 force-pushed the fix/callsites_output branch from 3a6c1d3 to 4eda0b2 Compare June 27, 2019 22:23
@artpol84
Copy link
Contributor Author

This should be a fairly easy one as well if I'm not missing something.

@artpol84 artpol84 mentioned this pull request Jul 28, 2019
Merged
@cchambreau
Copy link
Collaborator

I believe that this has been addressed recently with PR #27. The configure flag --enable-internal-stackdepth allows specifying internal stack frames. If not, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artpol84 @cchambreau