Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add retry to attestation cert fetch #419

Closed
wants to merge 11 commits into from

Conversation

joshLong145
Copy link

Description

There have been cases where there is failure when attempting to remote fetch AMD SEV SNP certificates for attestation checks. executeWithRetry is no wrapping the request to allow for retry if the operation fails
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@joshLong145 joshLong145 marked this pull request as draft April 11, 2024 19:37
@joshLong145
Copy link
Author

joshLong145 commented Apr 11, 2024

Putting to draft as i work out the failing connection test

@joshLong145
Copy link
Author

Closing for an alternate strategy of converging environments on the CORS proxy url to prevent AMD rate limiting certificate fetching.

@joshLong145 joshLong145 deleted the ref/add-retry-to-cert-fetching branch April 15, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant