Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts-sdk): move the older multiformats dependency from peerD… #404

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Mar 20, 2024

Wrong version of multiformats package breaking @lit-protocol/contracts-sdk #403

Description

#403

The multiformats package is only used in the contracts-sdk, so this issue wouldn't affect any other packages. It's currently attempting to require multiformats v12.x , which problematically is an ESM module and doesn't match our peer dependency in the contracts-sdk package.json.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…ependencies to dependencies

Wrong version of multiformats package breaking @lit-protocol/contracts-sdk #403
Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the lockfile updated also, otherwise LGTM!

@Ansonhkg Ansonhkg requested a review from MaximusHaximus March 20, 2024 18:15
glitch003
glitch003 previously approved these changes Mar 20, 2024
Copy link
Collaborator

@glitch003 glitch003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the quick turnaround on this!

@Ansonhkg Ansonhkg merged commit 3b8cc81 into master Mar 21, 2024
4 checks passed
@Ansonhkg Ansonhkg deleted the feature/lit-2682-wrong-version-of-multiformats-package-breaking-in-lit branch March 21, 2024 12:44
Ansonhkg added a commit that referenced this pull request Mar 21, 2024
Ansonhkg added a commit that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants