Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/logging storage #347

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Ref/logging storage #347

merged 2 commits into from
Feb 8, 2024

Conversation

joshLong145
Copy link

Description

Removes functionality for persisting logs to localStorage as with high number of requests being persisted will go over the allowed maximum of 10mb stored for a single origin.

in code there is a comment outlining next steps to allow for self deleting log storage.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Used current logging tests to confirm that logs are no longer going into a localStorage instance

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@joshLong145 joshLong145 requested a review from Ansonhkg as a code owner February 8, 2024 15:37
@joshLong145 joshLong145 changed the base branch from master to staging/3.1.3 February 8, 2024 15:38
@Ansonhkg Ansonhkg merged commit 2bff77e into staging/3.1.3 Feb 8, 2024
4 checks passed
@Ansonhkg Ansonhkg deleted the ref/logging-storage branch February 8, 2024 17:54
@Ansonhkg Ansonhkg mentioned this pull request Feb 8, 2024
5 tasks
Ansonhkg added a commit that referenced this pull request Feb 13, 2024
* staging 3.1.3

* Feature/lit 2096 add json schema runtime assertions for access control (#320)

* add json schema validation for acc

* add script to build interfaces

* replace mapping structure with getter function with validation for missing schemas

* fix promise handling when writing ts interfaces files

* add unit test to safeguard devs into deploying mismatching TS interfaces and JSON schemas

* update JSON schemas and their TS interfaces

* schemas and clases fixes

* add successful test cases

* move ACC types definitions to types project

* update new schemas

* use new types inferred from schemas

* fmt

* strongly type flattenAndFilter function to preserve values type

* move schema validation to access-control-conditions package

* move ajv creation outside of checkSchema function to avoid creating it over and over

* fmt

* use classes and schemas from lit-accs-validator package

* fixes to avoid multiple compiles and avoid false negatives on valid unified acc schemas

* change local version of acc validator package to published one

* update accs-validator version and fix it

* fmt

* remove tools script not needed anymore

* Feature/lit 2413 js sdk re introduce request per second when minting rli (#345)

* feat: different context when minting rli

* feat: add context on minting rli

* chore: update test cases

* feat: add utils for conversions

* fix: round up

* fix: conversion

* fix: tests

* chore: update scripts

* fix: stricter check

* fix: stricter check

* fix: stricter check

* fix: add diff types

* prettified

* fix: add accs-validator to ignoreList (#348)

* Ref/logging storage (#347)

* remove local storage persistence with comment for future refactor

* fmt

* Fix/claim processor default handler (#351)

* make relayUrls constants and use in defaultMintCallback

* auto

* fmt

* Feature/lit 2406 add support for handshaking with nodes after on chain events (#346)

* support re connect after active node set change

* fmt

* pr review

* fmt

* Feature/lit 2407 implicit network handing shaking after `connect` (#350)

* support re connect after active node set change

* fmt

* pr review

* wip add timestamp on handshake with nodes

* update latest block hash to refresh aftrer expiration

* fix test

* fmt

* use interval over explicit network refresh in getLatestBlockhash

* tweak to test wait time

* add checks for old and new state equality

* fmt

* remove await

* fix blocking

* fix: review changes

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Anson <[email protected]>

* Feat/local env network bootstrapping (#352)

* support re connect after active node set change

* fmt

* pr review

* wip add timestamp on handshake with nodes

* update latest block hash to refresh aftrer expiration

* fix test

* fmt

* use interval over explicit network refresh in getLatestBlockhash

* tweak to test wait time

* add checks for old and new state equality

* fmt

* remove await

* fix blocking

* custom contract resolving

* fmt

* fix: typo environment

* chore: move folder to manual test

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Ansonhkg <[email protected]>

* fix: accs-validator pkg name

* fix: update ignoreList

* fix: imports

* fix: update test-contracts-get-read-validators.mjs

* update changelog

* Fix/passthrough tests (#353)

* remove action execution from test

* fmt

* remove message hashing

* fix: e2e requires minting capacity credits NFT (#354)

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Federico Amura <[email protected]>
Co-authored-by: Bean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants