-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/logger #267
Merged
Merged
Add/logger #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of throwing
…e-client-nodejs package
…st arrayify utf-16 strings
* feat: Store blockhash from handshake + use it in SIWE * feat: Pass blockhash instead of client in authSig functions * refac: Cleanup * feat: Client getter for blockhash + Manual tests * refac: Remove comments * refac: latest_blockhash -> latestBlockhash * test: Display result of manual tests * test: Node E2E test for creating authSig by fetching the blockhash from the client
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated into
core
by injecting thelog manager
and a singlelogger
intolit-core
by global injectionExamples
Using the
LogManager
to create a new loggerUsing the
LogManager
to set logging levels for all loggersAdding a
handler
for all loggersTurning hashing support on for all loggers
The above can be done on individual loggers for single instance modifications
Next Steps
debug
option to alog level
option for finer grade log support.